Use EventSubscription to unsubscribe from BackHandler #410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RN 0.77.0 contains a PR removing `removeEventListener` from `BackHandler` (facebook/react-native#45892) This PR uses suggested migration of using `remove` on `EventSubscription`
retyui
approved these changes
Feb 3, 2025
12 tasks
|
👋 @pvinis, can you take a look to this change ? |
pvinis
approved these changes
Feb 7, 2025
|
❤️ |
|
@pvinis Unfortunatly, looks like CI is blocked (canary + release) |
|
I'll have to take a look next week. if you know what's up, can you make a PR? |
|
@pvinis could you please release this? |
|
I'll do it tomorrow 👍 |
|
@fobos531 done 👍 |
|
Thanks @pvinis ! I noticed that the versioning now starts with 100, a big jump from 2/3. Is this normal? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
RN 0.77.0 contains a PR removing
removeEventListenerfromBackHandler(facebook/react-native#45892)This PR uses suggested migration of using
removeonEventSubscription